[syslinux] [PATCH] pxe: fix OACK packet handling
liu Aleaxander
aleaxander at gmail.com
Sat Aug 8 07:47:32 PDT 2009
Hi sebastian, Thanks for hacking my gsoc code so quickly!
On Sat, Aug 8, 2009 at 9:29 PM, Sebastian Herbszt <herbszt at gmx.de> wrote:
> - dst = src = options;
> - while (buffersize--) {
> - if (*src == 0)
> - break; /* found a final null */
> - *dst++ = *src++ | 0x20;
> - if (!buffersize)
> - goto done; /* found no final null */
> - }
> -
> + if (*(options + buffersize - 1) != 0)
> + goto done; /* found no final null */
> +
>
Yeah, this make the things much easier, but should we make sure the options
are converted to low-case? Because the strings in the tftp_options are all
in low-case, and I'm not sure the options are all transfromed in the
low-case.
And last, thanks for your patch!
--
regards
liu Aleaxander
More information about the Syslinux
mailing list