[syslinux] Absolutely last call for 3.82, misleading error
Geert Stappers
stappers at stappers.nl
Mon Jun 8 14:14:16 PDT 2009
Op 20090608 om 09:58 schreef H. Peter Anvin:
> I'm going to push out a Syslinux 3.82 later today unless someone yells...
pxelinux.asm has only 1 error reply message
which is used and abused in all error cases.
I can't reproduced it
a PXE / TFTPD server does trigger the behaviour.
I have been looking in the tftpd-hpa to create pxelinux.0 misbehaviour.
--- a/tftpd/tftpd.c
+++ b/tftpd/tftpd.c
@@ -1489,7 +1489,7 @@ static void tftp_sendfile(struct formats *pf,
struct tftph
(void)sigsetjmp(timeoutbuf, 1);
oack:
r_timeout = timeout;
- if (send(peer, oap, oacklen, 0) != oacklen) {
+ if (send(peer, oap, (oacklen+1), 0) != (oacklen+1)) {
syslog(LOG_WARNING, "tftpd: oack: %m\n");
goto abort;
}
does compile, but not tested / checked.
See also http://syslinux.zytor.com/archives/2009-June/012690.html
Stappers
More information about the Syslinux
mailing list