[syslinux] [PATCH 12/23] com32/chain: cleaner variable names

Shao Miller sha0.miller at gmail.com
Thu Nov 8 08:18:30 PST 2012


On 11/5/2012 19:32, Michal Soltys wrote:
> diff --git a/com32/chain/partiter.c b/com32/chain/partiter.c
> index da96b3d..14e74de 100644
> --- a/com32/chain/partiter.c
> +++ b/com32/chain/partiter.c
> @@ -302,16 +302,14 @@ static int prep_base_ebr(struct part_iter *iter)
>
>       if (iter->dos.bebr_index0 < 0)	/* if we don't have base extended partition at all */
>   	return -1;
> -    else if (!iter->dos.bebr_start) { /* if not initialized yet */
> +    else if (!iter->dos.bebr_lba) { /* if not initialized yet */
>   	dp = ((struct disk_dos_mbr *)iter->data)->table + iter->dos.bebr_index0;
>
> -	iter->dos.bebr_start = dp->start_lba;
> -	iter->dos.bebr_size = dp->length;
> +	iter->dos.bebr_lba = dp->start_lba;
> +	iter->dos.bebr_siz = dp->length;
>
> -	iter->dos.ebr_size = iter->dos.bebr_size;
> -
> -	iter->dos.cebr_lba = 0;
> -	iter->dos.nebr_lba = iter->dos.bebr_start;
> +	iter->dos.nebr_lba = dp->start_lba;
> +	iter->dos.nebr_siz = dp->length;
>
>   	iter->index0--;
>       }

The last two change-lines in this hunk appear to do more than just 
change to using "cleaner variable names."  Is this a copy'n'paste error 
from the two change-lines that came before?

- Shao Miller



More information about the Syslinux mailing list