[syslinux] [GIT PULL] Remove duplicate COM32 modules
Ady
ady-sf at hotmail.com
Wed Oct 24 07:57:48 PDT 2012
> On Tue, 2012-05-22 at 21:21 -0300, André Ericson wrote:
> > The following changes since commit 4fc3fd1e14f4c1b9208ef262e5b6aef853e9fce4:
> >
> > graphics: make use of syslinux_force_text_mode() (2012-05-19 02:05:38 -0300)
> >
> > are available in the git repository at:
> >
> > git://github.com/aericson/syslinux.git elflink
> >
> > for you to fetch changes up to 2779b713bdd8644ee2b52962ece6daa209b4ba6b:
> >
> > com32: remove duplicate modules (2012-05-22 20:59:51 -0300)
> >
> > ----------------------------------------------------------------
> > Andre Ericson (1):
> > com32: remove duplicate modules
> >
> > com32/modules/Makefile | 3 +--
> > com32/modules/hello.c | 26 --------------------------
> > com32/samples/hello.c | 37 ++++++++++++++-----------------------
> > 3 files changed, 15 insertions(+), 51 deletions(-)
> > delete mode 100644 com32/modules/hello.c
>
> Pulled, thanks!
>
> --
> Matt Fleming, Intel Open Source Technology Center
Hi Matt,
Is (are) the resulting com32 module(s) (after the clean up) going to
work just as before?
The reason I ask is because each hello.c is DIFFERENT:
_ in 4.06:
./com32/samples/hello.c
./com32/samples/hello.c32
./win/hello.c
and
./com32/lua/test/hello.lua
./com32/samples/fancyhello.c
./com32/samples/fancyhello.c32
./com32/samples/fancyhello.lnx
_ in 4.10-pre22 (same as 4.06):
./com32/samples/hello.c
./com32/samples/hello.c32
./win/hello.c
and
./com32/lua/test/hello.lua
./com32/samples/fancyhello.c
./com32/samples/fancyhello.c32
./com32/samples/fancyhello.lnx
_ in 5.00-pre8
./com32/samples/hello.c
./com32/samples/hello.c32
./com32/modules/hello.c
./com32/modules/hello.c32
./core/hello.c
./win/hello.c
and
./com32/lua/test/hello.lua
./com32/samples/fancyhello.c
./com32/samples/fancyhello.c32
./com32/samples/fancyhello.lnx
So the modules are not exactly duplicates.
About core and win, either hello.c32 modules are not being built, or
the C files therein are unnecessary? Or are they there for
convenience (for someone)?
(Note: I'm just pointing out this since you are cleaning up; I'm not
really asking.)
Best Regards,
Ady.
More information about the Syslinux
mailing list