[syslinux] [syslinux:firmware] efi, udp: implement receive timeout
H. Peter Anvin
hpa at zytor.com
Fri Jul 12 09:54:43 PDT 2013
On 07/12/2013 05:57 AM, syslinux-bot for Matt Fleming wrote:
> Commit-ID: 7ab8f23aa2140951608544ed557f7529cf32d98d
> Gitweb: http://www.syslinux.org/commit/7ab8f23aa2140951608544ed557f7529cf32d98d
> Author: Matt Fleming <matt.fleming at intel.com>
> AuthorDate: Fri, 12 Jul 2013 13:47:22 +0100
> Committer: Matt Fleming <matt.fleming at intel.com>
> CommitDate: Fri, 12 Jul 2013 13:53:07 +0100
>
> efi, udp: implement receive timeout
>
> We currently wait indefinitely in core_udp_recv() when reading packets.
> Implement a timeout, which is what all the other network stacks do. By
> timing out we are now able to handle packet loss on the network, e.g.
> we'll now re-send TFTP requests instead of waiting for ACK packets that
> will never come.
>
Hmmm.
We already have a timeout loop in tftp_get_packet() as well as in the
legacy version of dns_resolv().
I would like to suggest we augment the generic UDP receive function call
with a timeout, rather than implementing a timeout upon a timeout.
What do you think?
-hpa
More information about the Syslinux
mailing list