[syslinux] mk/efi.mk: Add libefi.a dependency

[Gene Cumm]

On Sun, Feb 23, 2014 at 3:14 PM, Geert Stappers <stappers at stappers.nl> wrote:
> .From the commit mailinglist
> Op 2014-02-23 om 10:57 schreef syslinux-bot for Gene Cumm:
>> Commit-ID:  819783d0c8b5af43423e9e5bbe0e233c728d6346
>> Gitweb:     http://www.syslinux.org/commit/819783d0c8b5af43423e9e5bbe0e233c728d6346
>> Author:     Gene Cumm <gene.cumm at gmail.com>
>> AuthorDate: Sat, 22 Feb 2014 12:00:47 -0500
>> Committer:  Gene Cumm <gene.cumm at gmail.com>
>> CommitDate: Sat, 22 Feb 2014 12:00:47 -0500
>>
>> mk/efi.mk: Add libefi.a dependency
>>
>> Signed-off-by: Gene Cumm <gene.cumm at gmail.com>
>>
>> ---
>>  mk/efi.mk | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/mk/efi.mk b/mk/efi.mk
>> index 3390cfc..f90ce5c 100644
>> --- a/mk/efi.mk
>> +++ b/mk/efi.mk
>> @@ -55,11 +55,11 @@ $(LIBEFI):
>>  %.o: %.c
>>
>>  .PRECIOUS: %.o
>> -%.o: %.S
>> +%.o: %.S $(LIBEFI)
>>       $(CC) $(SFLAGS) -c -o $@ $<
>>
>>  .PRECIOUS: %.o
>> -%.o: %.c
>> +%.o: %.c $(LIBEFI)
>>       $(CC) $(CFLAGS) -c -o $@ $<
>>
>
> I see duplicate lines.
> Why do they exist?
>
> Would
> --- a/mk/efi.mk
> +++ b/mk/efi.mk
> @@ -58,10 +58,6 @@ $(LIBEFI):
>  %.o: %.S $(LIBEFI)
>         $(CC) $(SFLAGS) -c -o $@ $<
>
> -.PRECIOUS: %.o
> -%.o: %.c $(LIBEFI)
> -       $(CC) $(CFLAGS) -c -o $@ $<
> -
>  #%.efi: %.so
>  #      $(OBJCOPY) -j .text -j .sdata -j .data -j .dynamic -j .dynsym -j .rel \
>  #              -j .rela -j .reloc --target=$(FORMAT) $*.so $@
> make sense?

The two rules look similar but have very different prerequisites and
recipes.  Both make .o files but one is from .S files and the other
from .c files, each needing slightly different recipes.

-- 
-Gene