[syslinux] EFI: HP + syslinux = crash [ brown paper bag update ]
Gene Cumm
gene.cumm at gmail.com
Sun Sep 13 06:52:30 PDT 2015
On Sun, Sep 13, 2015 at 9:22 AM, Patrick Masotta <masottaus at yahoo.com> wrote:
>
>>>>
> > It is also working here; I think this particular PNG issue is fixed.
> >
> > It's worth to mention that the replaced code looks valid to me; that's why I think
> > this is probably some sort of compiler bug. It was really hard to find.
> > We should keep an eye on this issue; it might appear somewhere else.
>
> Eww. The original code was merely an empty
> define. That's pretty nasty.
>
> Alternatively, we could void them
>
> -# define Assert(cond,msg)
> +# define Assert(cond,msg) ((void)0)
>
> --
> -Gene
> <<<
>
>
> The empty define should work; actually it did work for many years...
>
> Your just proposed change was my first attempt for solving this but for some
> reason it did not work. After testing a lot the only way I've found to solve this
> bug was defining a "real" empty function. I know, 100% hacky but it works.
If the voiding doesn't work, we'll need that function in another 44
lines of code, spread throughout the source.
--
-Gene
More information about the Syslinux
mailing list