aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorErwan Velu <erwan@enovance.com>2014-01-29 20:28:08 +0100
committerGene Cumm <gene.cumm@gmail.com>2014-02-01 07:59:33 -0500
commit003a288a03c2384bd42b36edbe3bf13714f84700 (patch)
tree6229f915dcaba430f3dad4d493c24a7916236ba5
parentcee0d66107fcd29c7ad4df0572d190a83917f29d (diff)
downloadsyslinux-003a288a03c2384bd42b36edbe3bf13714f84700.tar.gz
syslinux-003a288a03c2384bd42b36edbe3bf13714f84700.tar.xz
syslinux-003a288a03c2384bd42b36edbe3bf13714f84700.zip
acpi: Removing memset of buffer
There is no need to memset the buffer since the strncat will end the string with a \0. The memset was also almost wrong as doing a sizeof() on a char * could return 1 if buff was malloc'ed. We had chance as all the current calls are done with static buffers. Removing this memset call will make things clearer but also will prevent compilation warnings like : com32/gpllib/acpi/acpi.c:38:29: warning: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess] memset(buffer, 0, sizeof(buffer));
-rw-r--r--com32/gpllib/acpi/acpi.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/com32/gpllib/acpi/acpi.c b/com32/gpllib/acpi/acpi.c
index d2bf29e5..3013f196 100644
--- a/com32/gpllib/acpi/acpi.c
+++ b/com32/gpllib/acpi/acpi.c
@@ -35,7 +35,6 @@
/* M1PS flags have to be interpreted as strings */
char *flags_to_string(char *buffer, uint16_t flags)
{
- memset(buffer, 0, sizeof(buffer));
strcpy(buffer, "default");
if ((flags & POLARITY_ACTIVE_HIGH) == POLARITY_ACTIVE_HIGH)
strcpy(buffer, "high");