[syslinux] unknown boot options on kernel command line. (kernel patch for COMMAND_LINE_SIZE)

Jim Cromie jcromie at divsol.com
Mon Jun 13 06:47:05 PDT 2005


Geert Stappers wrote:

>On Thu, Jun 09, 2005 at 08:59:31AM -0600, Jim Cromie wrote:
>  
>
>>Jim Cromie wrote:
>>
>>    
>>
>>>changing i386 COMMAND_LINE_SIZE to 1024
>>>
>>>      
>>>
>>cripes - heres that patch.
>>    
>>
>
>  
>
>>--- lnew/include/asm-i386/setup.h~	2005-06-07 13:34:14.000000000 -0600
>>+++ lnew/include/asm-i386/setup.h	2005-06-08 13:33:12.000000000 -0600
>>@@ -17,7 +17,7 @@
>> #define MAX_NONPAE_PFN	(1 << 20)
>> 
>> #define PARAM_SIZE 4096
>>-#define COMMAND_LINE_SIZE 256
>>+#define COMMAND_LINE_SIZE 1024
>> 
>> #define OLD_CL_MAGIC_ADDR	0x90020
>> #define OLD_CL_MAGIC		0xA33F
>>--- lnew/include/asm-i386/param.h~	2005-06-07 13:35:23.000000000 -0600
>>+++ lnew/include/asm-i386/param.h	2005-06-08 13:33:29.000000000 -0600
>>@@ -20,6 +20,6 @@
>> #endif
>> 
>> #define MAXHOSTNAMELEN	64	/* max length of hostname */
>>-#define COMMAND_LINE_SIZE 256
>>+#define COMMAND_LINE_SIZE 1024
>> 
>> #endif
>>    
>>
>
>
>Is this a part that other missed also?
>
>
>  
>
not entirely sure what youre asking..
yes, I sent the same patch <cough> 2x.  Bad email day.

<aside>
Sometimes I wish I had one of those MS-idiot buttons;
"Did you attach that attachment yet"  Except it should work.
(ie read the msg, and find 'patch' or 'attachment' in context,
and ask only when its seen and nothings attached.)
</>

BTW, since HPA has been mostly disconnected lately,
I sent patch to Dave Jones, the other i386 boot Linux Kernel Maintainer.
He was ok with it, forwarded to Andrew Morton, who replied
(to Dave & me, but didnt add on hpa):

We had some nasty problem when we tried to do this on x86-64 recently.

It would be best to wait until hpa has had a think about it.


Curtis, since youre hacking at syslinux, could you try 3.08 proper,
rather than pre-10 or 11 ? (or is pre-10 same as released?)
It looks like your patch (or parts of it) are in 3.08 already.
But then theres that nasty -R in there ;-)

Once I patched len to 1024, my kernel sees the full commandline sent,
and acts accordingly.  Im using menu.c32. but no DISPLAY - the menu
gives me what I need, and I dont have to keep a display-file in sync 
with it.

>Cheers
>Geert Stappers
>  
>




More information about the Syslinux mailing list