[syslinux] Regarding: Question on menu/Makefile

[H. Peter Anvin]

Michael D. Setzer II wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Here is the strange thing. I changed the Makefile back, and even after a make clean and then 
> make didn't get the error. I then extracted the 3.54 to a different directory, and ran the make 
> in the menu directory, and get the error message.  
> 
> libmenu/help.c:17:57: error: loadfile.h: No such file or directory
> libmenu/help.c: In function 'showhelp':
> libmenu/help.c:99: warning: implicit declaration of function 'loadfile'
> make: *** [libmenu/help.o] Error 1
> 
> The loadfile.h is in the include/syslinux directory, and that is why I added it to the Makefile to 
> get it to compile without the error.
> 
> CFLAGS     = $(M32) -mregparm=3 -DREGPARM=3 -W -Wall -march=i386 -Os -fomit-frame-pointer -I$(LUDIR)/include -I$(COM32DIR)/include -I$(COM32DIR)/include/syslinux  -Ilibmenu -D__COM32__
> 
> The addition of the -I$(COM32DIR)/include/syslinux then includes that directory as well. 
> 
> So, the error would not occur if at some point the libmenu/help.o had been already compiled. 
> 

Right, that makes sense.

The right thing to do would be to explicitly add syslinux/ to the 
#include directives for headers that have moved into the syslinux/ 
namespace.

	-hpa