[syslinux] my_isspace can be isblank

[Ram Yalamanchili]

Hi Peter,

Here is a size comparision of resulting com32 modules with and without
the patch.

Build instructions: I did a make clean && make (with and without patches).

With my_isspace():
-rwxr-xr-x 1 ino ino   3592 2007-03-16 00:45 com32/modules/chain.c32
-rwxr-xr-x 1 ino ino   9732 2007-03-16 00:46 com32/modules/cpuidtest.c32
-rwxr-xr-x 1 ino ino  21204 2007-03-16 00:46 com32/modules/dmitest.c32
-rwxr-xr-x 1 ino ino   5284 2007-03-16 00:46 com32/modules/ethersel.c32
-rwxr-xr-x 1 ino ino  46252 2007-03-16 00:46 com32/modules/mboot.c32
-rwxr-xr-x 1 ino ino  29444 2007-03-16 00:46 com32/modules/menu.c32
-rwxr-xr-x 1 ino ino  10404 2007-03-16 00:46 com32/modules/pcitest.c32
-rwxr-xr-x 1 ino ino   8272 2007-03-16 00:46 com32/modules/safeboot.c32
-rwxr-xr-x 1 ino ino 114176 2007-03-16 00:46 com32/modules/vesamenu.c32

with glibc isblank():
-rwxr-xr-x 1 ino ino  3592 2007-03-16 00:47 com32/modules/chain.c32
-rwxr-xr-x 1 ino ino   9732 2007-03-16 00:47 com32/modules/cpuidtest.c32
-rwxr-xr-x 1 ino ino  21204 2007-03-16 00:47 com32/modules/dmitest.c32
-rwxr-xr-x 1 ino ino   5284 2007-03-16 00:47 com32/modules/ethersel.c32
-rwxr-xr-x 1 ino ino  46252 2007-03-16 00:47 com32/modules/mboot.c32
-rwxr-xr-x 1 ino ino  29572 2007-03-16 00:47 com32/modules/menu.c32
-rwxr-xr-x 1 ino ino  10404 2007-03-16 00:47 com32/modules/pcitest.c32
-rwxr-xr-x 1 ino ino   8272 2007-03-16 00:47 com32/modules/safeboot.c32
-rwxr-xr-x 1 ino ino 114176 2007-03-16 00:47 com32/modules/vesamenu.c32

menu.c32 is bigger by 128 bytes.

thanks.

--
Ram

On 3/15/07, H. Peter Anvin <hpa at zytor.com> wrote:
> Ram Yalamanchili wrote:
> > Hey,
> >
> > I noticed my_isspace() is being used in menu/mainmenu and readconfig
> > com32 modules.
> >
> > Why not use isblank() instead? Here's a patch:
>
> Did you compare the sizes of the resulting binaries?
>
>         -hpa
>