[syslinux] Patch: Allow args with spaces

[Sergey Vlasov]

On Thu, Dec 04, 2008 at 03:15:14PM +0100, Marcel Ritter wrote:
> + * dmiselect.c
> + *
> + * Run command depending on systems DMI information (example: system's
> + * product name. Options are pairs of value: <system name> <action>.
> + *
> + * Usage:
> + *
> + * label BIOSupdate
> + *   kernel dmiselect.c32
> + *   append "ESPRIMO P5925" "memdisk initrd=/dos/FSC-E5925.img raw" "ESPRIMO P7935" "memdisk initrd=/dos/FSC-P7935-108.img raw"

Good idea (unfortunately, not all machines can be flashed with memdisk
due to compatibility issues with protected mode); however, the
interface using a single long command line is not ideal.  The
ethersel.c32 module does a similar thing with PCI device IDs, but
reads the PCI ID list from a file.  IMHO this is better than using a
long command line (which currently has a 2047 character limit).

Also it would be nice to have support for matching other DMI strings,
not only system.product_name - so the file format should not have just
two fields per line.  E.g., something like this:

# DMI system.product_name "ESPRIMO P5925" -- "memdisk initrd=/dos/FSC-E5925.img raw"
# DMI system.product_name "ESPRIMO P7935" -- "memdisk initrd=/dos/FSC-P7935-108.img raw"

Other things might be possible - e.g., comparing bios.version with
strvercmp() (if the format used by the vendor allows it); so maybe the
current "starts_with" comparison operation should be made explicit:

# DMI system.product_name starts_with "ESPRIMO P5925" -- "memdisk initrd=/dos/FSC-E5925.img raw"
# DMI system.product_name starts_with "ESPRIMO P7935" -- "memdisk initrd=/dos/FSC-P7935-108.img raw"

(and later add operations like "version_le", "string_le", etc.).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.zytor.com/pipermail/syslinux/attachments/20081207/ebe9a6d8/attachment.sig>