[syslinux] [PATCH 1/1] COMBOOT API: Add get current working directory call to most
H. Peter Anvin
hpa at zytor.com
Sun Nov 9 17:21:49 PST 2008
Jeffrey Hutzelman wrote:
>>>
>> Okay, this isn't quite right, especially in the case of the TFTP prefix;
>> the TFTP prefix may not end in '/', especially when the TFTP server is
>> not a Unix system. Therefore I think this call should return a prefix
>> (including a final '/' in case of the filesystem-based variants.)
>
> I guess that depends on what it will be used for.
>
> If the intent is for callers to concatenate the returned string with a
> filename to get something they can open, then I agree.
>
> If the intent is for the returned string to be something that can be passed
> to opendir() (added in one of Gene's previous patches), then maybe not.
>
opendir() really shouldn't care. For the former case, however, it
really does matter.
By the way, Gene, this is all impressive work.
-hpa
More information about the Syslinux
mailing list