[syslinux] [PATCH 1/1] COMBOOT API: Add get current working directory call to most (revised)

Gene Cumm gene.cumm at gmail.com
Mon Nov 10 10:36:46 PST 2008


On Mon, Nov 10, 2008 at 12:30 PM, H. Peter Anvin <hpa at zytor.com> wrote:
> Gene Cumm wrote:
>>  ; This is what we need to do when idle
>> @@ -845,7 +846,7 @@ load_config:
>>               mov si,config_name      ; Save config file name
>>               mov di,ConfigName
>>               call strcpy
>> -             mov word[CurrentDirName], ROOT_DIR_WORD ; Write '/',0 to the CurrentDirName
>> +             mov dword[CurrentDirName], CUR_DIR_DWORD        ; Write './',0,0 to the
>
> Just a stylistic note: please put a space between the size specifier and
> the bracket.  This is significant especially since in some non-NASM
> assemblers, the syntax foo[bar] is used to mean [foo+bar].
>
>        -hpa
>

Thanks.




More information about the Syslinux mailing list