[syslinux] [Bugreport+Patch] Syslinux doesn't compile on Ubuntu Intrepid Ibex (8.10)

[Rorschach]

Hi,
because the only info I found on the wiki was this mailinglist I'm sending this mail here.

The newest syslinux (3.72 and the git-version) don't compile on the newest Ubuntu release: Intrepid Ibex (8.10). Folowing the compile errors:

[...]
cc1: warnings being treated as errors
drivers/net/3c595.c: In function ‘vxgetlink’:
drivers/net/3c595.c:366: error: format not a string literal and no format arguments
make[2]: *** [bin/3c595.o] error 1
make[2]: leaving directory '/working-directory/gpxe/src'
make[1]: *** [src/bin/undionly.kpxe] error 2
make[1]: leaving directory '/working-directory/gpxe'
make: *** [all] error 2
[...]
cc1: warnings being treated as errors
drivers/net/forcedeth.c: In function ‘reg_delay’:
drivers/net/forcedeth.c:455: error: format not a string literal and no format arguments
make[2]: *** [bin/forcedeth.o] error 1
make[2]: leaving directory '/working-directory/gpxe/src'
make[1]: *** [src/bin/undionly.kpxe] error 2
make[1]: leaving directory '/working-directory/gpxe'
make: *** [all] error 2
[...]
cc1: warnings being treated as errors
drivers/net/via-rhine.c: In function ‘rhine_probe1’:
drivers/net/via-rhine.c:1011: error: format not a string literal and no format arguments
make[2]: *** [bin/via-rhine.o] error 1
make[2]: leaving directory '/working-directory/gpxe/src'
make[1]: *** [src/bin/undionly.kpxe] error 2
make[1]: leaving directory '/working-directory/gpxe'
make: *** [all] error 2
[...]

After those errors the compilation aborts. I created the following patch, which fixes the errors:

diff -Naur syslinux-3.72/gpxe/src/drivers/net/3c595.c syslinux-3.72-new/gpxe/src/drivers/net/3c595.c
--- syslinux-3.72/gpxe/src/drivers/net/3c595.c	2008-09-26 01:46:02.000000000 +0200
+++ syslinux-3.72-new/gpxe/src/drivers/net/3c595.c	2008-10-08 17:41:56.000000000 +0200
@@ -363,7 +363,7 @@
         if (n > 0) {
           printf("/");
 	}
-        printf(conn_tab[k].name);
+        printf("%s",conn_tab[k].name);
         n++;
       }
     }
diff -Naur syslinux-3.72/gpxe/src/drivers/net/forcedeth.c syslinux-3.72-new/gpxe/src/drivers/net/forcedeth.c
--- syslinux-3.72/gpxe/src/drivers/net/forcedeth.c	2008-09-26 01:46:02.000000000 +0200
+++ syslinux-3.72-new/gpxe/src/drivers/net/forcedeth.c	2008-10-08 17:42:40.000000000 +0200
@@ -452,7 +452,7 @@
 		delaymax -= delay;
 		if (delaymax < 0) {
 			if (msg)
-				printf(msg);
+				printf("%s",msg);
 			return 1;
 		}
 	} while ((readl(base + offset) & mask) != target);
diff -Naur syslinux-3.72/gpxe/src/drivers/net/via-rhine.c syslinux-3.72-new/gpxe/src/drivers/net/via-rhine.c
--- syslinux-3.72/gpxe/src/drivers/net/via-rhine.c	2008-09-26 01:46:02.000000000 +0200
+++ syslinux-3.72-new/gpxe/src/drivers/net/via-rhine.c	2008-10-08 17:43:23.000000000 +0200
@@ -1008,7 +1008,7 @@
     unsigned char mode3_reg;
 
     if (rhine_debug > 0 && did_version++ == 0)
-	printf (version);
+	printf ("%s",version);
 
     // get revision id.
     pci_read_config_byte(pci, PCI_REVISION, &revision_id);

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://www.zytor.com/pipermail/syslinux/attachments/20081008/bf288ffe/attachment.sig>