[syslinux] SYSLINUX 3.73-pre3

[Dag Wieers]

On Tue, 14 Oct 2008, H. Peter Anvin wrote:

> I just pushed out SYSLINUX 3.73-pre3.  The only significant difference
> over -pre2 was changing MEMDISK to use "safeint" by default.

It fails to build on RHEL3 and RH9 with the following error:

----
gcc -std=gnu99 -m32  -mregparm=3 -DREGPARM=3 -march=i386 -Os -W -Wall -march=i386 -fomit-frame-pointer -D__COM32__ -nostdinc -iwithprefix include -I../../com32/libutil/include -I../../com32/include -c -o chain.o chain.c
In file included from chain.c:62:
../../com32/include/stdlib.h:15: warning: `_Exit' was declared `extern' and later `static'
ld -m elf_i386 -T ../../com32/lib/com32.ld -o chain.elf chain.o ../../com32/libutil/libutil_com.a ../../com32/lib/libcom32.a /usr/lib/gcc-lib/i386-redhat-linux/3.2.3/libgcc.a
../../com32/lib/libcom32.a(entry.o)(.init+0x23): In function `_start':
sys/entry.S:56: undefined reference to `COM32_ARGS'
make[2]: *** [chain.elf] Error 1
make[2]: Leaving directory `/dar/build/syslinux-3.73-pre3/com32/modules'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/dar/build/syslinux-3.73-pre3/com32'
make: *** [install] Error 2
----

I had this patch for it coming from you in the 3.72 release:

----
--- syslinux-3.72/com32/lib/sys/entry.S.orig    2008-09-27 02:20:18.000000000 +0200
+++ syslinux-3.72/com32/lib/sys/entry.S 2008-09-27 02:22:14.000000000 +0200
@@ -53,7 +53,7 @@
                 /* Copy COM32 invocation parameters */
                 leal 4(%esp),%esi               # Argument list
                 movl $__com32,%edi
-               movl $COM32_ARGS,%ecx
+               movl $(COM32_ARGS),%ecx
                 movl %esp,-4(%edi)              # Save the initial stack ptr
                 cmpl (%esi),%ecx
                 jbe 1f
----

Kind regards,
-- 
--   dag wieers,  dag at wieers.com,  http://dag.wieers.com/   --
[Any errors in spelling, tact or fact are transmission errors]