[syslinux] "keeppxe" broken in 3.74 - short-cycle 3.75
H. Peter Anvin
hpa at zytor.com
Wed Apr 15 09:00:28 PDT 2009
Gilles Espinasse wrote:
> The double ! in the patch look suspicious to me
> - m->allowedit = atoi(skipspace(p+12));
> + m->allowedit = !!atoi(skipspace(p+12));
>
!! is a meta-operator which means "turn this into a boolean". It's a
bit more portable[*] than a cast to (bool).
> Unrelated, I look at extlinux/main.c on git tree
> On HEAD, 'const char *program;' is duplicated (line 59 and 184) and line 184
> should be removed.
-hpa
[*] Specifially, it works even with hacks like
"typedef enum { false, true } bool;" to support legacy compilers.
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
More information about the Syslinux
mailing list