[syslinux] Syslinux 3.82-pre5, I really hope this is final...

[H. Peter Anvin]

[Cc: people who might find this version worth testing]

Geert Stappers wrote:
> 
> I have been looking in the tftpd-hpa to create pxelinux.0 misbehaviour.
> 
> --- a/tftpd/tftpd.c
> +++ b/tftpd/tftpd.c
> @@ -1489,7 +1489,7 @@ static void tftp_sendfile(struct formats *pf,
> struct tftph
>          (void)sigsetjmp(timeoutbuf, 1);
>        oack:
>          r_timeout = timeout;
> -        if (send(peer, oap, oacklen, 0) != oacklen) {
> +        if (send(peer, oap, (oacklen+1), 0) != (oacklen+1)) {
>              syslog(LOG_WARNING, "tftpd: oack: %m\n");
>              goto abort;
>          }
> 
> does compile, but not tested / checked.
> 

This does indeed show that an extra trailing zero causes PXELINUX to
puke, which really is rather unnecessary (be liberal in what you
receive.)  And yes, a misleading error message is annoying at best (be
conservative in what you send.)

So I decided this was worth a 3.82-pre5, however, I really don't want to
sit on 3.82-preX any longer, so any help testing it would be appreciated.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.