[syslinux] [PATCH 4/5] COM32: add trivial stat() function

Gene Cumm gene.cumm at gmail.com
Wed Mar 4 18:23:35 PST 2009


On Wed, Mar 4, 2009 at 8:42 PM, Keith Schincke <keith.schincke at gmail.com> wrote:
> Hi Gene,
>
>  1) Could you set ret equal to -1 when you define the variable? This would
> keep you from needing to use code space, program time to set it later.
>  2) Why do you set errno to 0 before your call to opendir()? Shouldn't this
> be set to 0 if the opendir() call is successful?

1-- I think I did something similar in another function but forgot to
go back and fix that in this function.  Thanks for pointing it out.
2-- I set errno to zero as it may contain an error I want to ignore
but you do have a good point.  opendir() will set errno as it needs.

-- 
-Gene




More information about the Syslinux mailing list