[syslinux] [PATCH 1/1] CORE/writedec: Fix overflow and redeclaration

Gene Cumm gene.cumm at gmail.com
Tue Mar 17 13:34:59 PDT 2009


On Tue, Mar 17, 2009 at 2:03 PM, H. Peter Anvin <hpa at zytor.com> wrote:
> Gene Cumm wrote:
>>
>> From: Gene Cumm <gene.cumm at gmail.com>
>>
>> CORE/writedec: Fix overflow and redeclaration; If EDX is greater than
>> or equal to 10, div can cause an overflow.  Comment out declaration of
>> writechr.
>>
>> Signed-off-by: Gene Cumm <gene.cumm at gmail.com>
>>
>> ---
>>
>> Against current head.
>>
>> hpa: If there's a preferred way to do what this function provides, let
>> me know.  Was the writechr in there on purpose to prevent the use of
>> this function?
>>
>
> No, it was just never actually tested since there was no user for it.
>

OK.

-Gene




More information about the Syslinux mailing list