[syslinux] fsc branch and Bochs

[H. Peter Anvin]

On 09/02/2009 03:44 PM, Sebastian Herbszt wrote:
> 
> Maybe the code should clear packet_buf and udp_read?
> 
> The code checks for
> 
>        /* Make sure the packet actually came from the server */
>        if (udp_read.src_ip == open_file->tftp_remoteip) {
>            printf("break!\n");
>            break;
>        }
> 
> and since udp_read.src_ip still seems to be valid it does exit the while
> loop.
> 
> A possible fix would be to use
> 
>        if (!err && (udp_read.src_ip == open_file->tftp_remoteip)) {
>            printf("break!\n");
>            break;
>        }
> 
> instead and only check if "err = pxe_call(PXENV_UDP_READ, &udp_read);"
> didn't error.
> 

Yes, something like that.  If the read returned an error the buffer is
undefined.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.