[syslinux] Chainc.32 missing some \n one error messages

[Kim Mik]

From: Kim Mik <kimmik999999 at yahoo.co.uk>
To: For discussion of Syslinux and tftp-hpa <syslinux at zytor.com>
Sent: Tuesday, 29 September, 2009 22:21:39
Subject: Re: [syslinux] Chainc.32 missing some \n one error messages

> From: Kim Mik <kimmik999999 at yahoo.co.uk>
> To: syslinux at zytor.com
> Sent: Monday, 17 August, 2009 1:30:04
> Subject: [syslinux] Chainc.32 missing some \n one error messages
> 
> I got the following message with chain.c32
> =====================
> Loader file too largeBoot:
> =====================
> 
> Like you can see, there should be a new line after 'large'.
> 
> I guess that some other error messages, will result in the same behavior.
> 
> 
> Gert Hulselmans
> 
> 
> $ diff -u com32/modules/chain.c.old com32/modules/chain.c.new
> 
> --- com32/modules/chain.c.old    2009-08-17 01:06:11.887394937 +0200
> +++ com32/modules/chain.c.new    2009-08-17 01:11:33.656402727 +0200
> @@ -446,7 +446,7 @@
>      mmap = syslinux_memory_map();
> 
>      if (!mmap) {
> -    error("Cannot read system memory map");
> +    error("Cannot read system memory map\n");
>      return;
>      }
> 
> @@ -547,11 +547,11 @@
>      return;
> 
> too_big:
> -    error("Loader file too large");
> +    error("Loader file too large\n");
>      return;
> 
> enomem:
> -    error("Out of memory");
> +    error("Out of memory\n");
>      return;
> }
> 
> @@ -614,7 +614,7 @@
>      } else if (!strncmp(argv[i], "seg=", 4)) {
>          uint32_t segval = strtoul(argv[i] + 4, NULL, 0);
>          if (segval < 0x50 || segval > 0x9f000) {
> -         error("Invalid segment");
> +        error("Invalid segment\n");
>          goto bail;
>          }
>          opt.seg = segval;


This patch isn't in Syslinux 3.83-pre11.

It can be pulled from Erwan's repo:
Correct link: http://git.zytor.com/?p=users/erwan/hdt.git;a=commit;h=d5d1a306ce4926f907ace0a7cb79e540cadb77c1

Gert Hulsemans