[syslinux] [PATCH] git tree: libfat, chain, mtools/syslinux, menu.txt

H. Peter Anvin hpa at zytor.com
Wed Aug 25 13:42:22 PDT 2010


On 08/20/2010 04:57 PM, Gene Cumm wrote:
> -libfat: A check for NULL pointers; A change to allow for a short
> FAT/too many sectors (depending on perspective); Try trimming the
> in-memory values to deal with the corruption, if possible.

I'm confused about ca8cade1f86cd22c8dfbdd199bd611df35c1cb92.

The purpose of the checks in libfat_open() is to make sure we throw an
error rather than end up corrupting a live filesystem.  As far as I can
read, it looks like the end result of this code is that we functionally
"defang" the sanity check?

It makes me very nervous, and I really want to get more of an explanation.

	-hpa




More information about the Syslinux mailing list