[syslinux] Problem with short options (4.02).

[Arwin Vosselman]

Hello,

On Fri, 30 Jul 2010 13:34:26 +0200, I wrote:

>F.i. "syslinux -s a:" results in:
>
>Unknown option: -s
>Usage: etc.
>
>With the long option "syslinux --stupid a:" however everything is ok.

I think I got it. It's only "stupid", that showing this behavior.

In 'libinstaller/syslxopt.c' on line 71 the "s" (undercast) is missing in:

   const char short_options[] = "t:fid:UuzS:H:rvho:OM:ma";

Adding the 's' there seems to solve our problem.

Patch for 4.02:

--- syslinux-4.02/libinstaller/syslxopt.c~  2010-07-31 17:03:07.333049095
+0200
+++ syslinux-4.02/libinstaller/syslxopt.c   2010-07-31 17:03:07.363550307
+0200
@@ -68,7 +68,7 @@
     {0, 0, 0, 0}
 };

-const char short_options[] = "t:fid:UuzS:H:rvho:OM:ma";
+const char short_options[] = "t:fid:UuzsS:H:rvho:OM:ma";

 void __attribute__ ((noreturn)) usage(int rv, enum syslinux_mode mode)
 {

-- 
Regards,
Arwin.