[syslinux] [PATCH 1/2] linux/syslinux.c: Silence warnings

Gene Cumm gene.cumm at gmail.com
Sat Jun 19 19:00:48 PDT 2010


On Sat, Jun 19, 2010 at 20:01, H. Peter Anvin <hpa at zytor.com> wrote:
> On 06/19/2010 05:11 AM, Gene Cumm wrote:
>>
>> From: Gene Cumm<gene.cumm at gmail.com>
>>
>> linux/syslinux.c: Silence warnings from GCC with asprintf's attribute
>> warn_unused_result in certain glibc versions/patches.  Assign it to a
>> variable and ignore it as the string is already tested for null before
>> using it.
>>
>> Signed-off-by: Gene Cumm<gene.cumm at gmail.com>
>>
>
> Okay, what *blithering idiot* put warn_unused_result on *asprintf*?!!!!
>
>        -hpa
>

Sometimes this use of the warn_unused_result attribute seems a little
redundant.  If you check the results the other way, you should know
what happened or if there was an error.

--
-Gene




More information about the Syslinux mailing list