[syslinux] [PATCH] chain.c32: add support for loading GRUB stage2

[Paul Bolle]

On Tue, 2010-06-29 at 06:55 -0400, Shao Miller wrote:
> Paul Bolle wrote:
> > - update the usage comment and the usage string;
> 
> Yeah "chain.c32 [boot][[" "|","]<partition>] [options]" might be more 
> appropriate.

Maybe
 
    chain.c32 [boot] [<partition>] [options]
    chain.c32 boot,<partition> [options]

is more readable. But perhaps the "boot," variant can be deprecated.

> > - s/drivename/argument/g;
> 
> The only exception where "drivename" might not be the name of the drive 
> to boot would be using "guid:" or "label:" or "fs". 

"boot" is not a drivename either.

> For the "guid:" 
> case, it still might specify the GUID of a GPT drive.  Does "drivename" 
> give a little more meaning than "argument" to a reader?

It was one of the things that contributed to my confusion.

> > - disallow setting a partition for the "fs" argument;
> 
> Good point.
> 
> > - do not allow arguments like "hd1,2" (that should be "hd1 2" instead);
> 
> Why?

To me it looked like an GRUB'ism that was only allowed by accident. (It
also made this patch easier to write.)

> People use "chain.c32 hd1,2".

I didn't find examples of that use. It is also undocumented. (But if
it's supposed to be supported it could of course easily be documented.)


Paul