[syslinux] vesamenu.c32: Last line of HELP MSG does not appear

[Miller, Shao]

-----Original Message-----
From: syslinux-bounces at zytor.com [mailto:syslinux-bounces at zytor.com] On
Behalf Of Sven-Hendrik Haase
Sent: Friday, December 04, 2009 05:26
To: For discussion of Syslinux and tftp-hpa
Subject: Re: [syslinux] vesamenu.c32: Last line of HELP MSG does not
appear

On 04.12.2009 05:18, H. Peter Anvin wrote:
> On 12/03/2009 05:32 PM, Sven-Hendrik Haase wrote:
>   
>> This appears to be a bug:
>> In case the TEXT HELP for a menu entry extends over several lines and
>> you manually set MENU HELPMSGROW and MENU HELPMSGENDROW, the last
line
>> of the TEXT HELP will not be visible.
>> Concrete example:
>> MENU HELPMSGROW 24
>> MENU HELPMSGENDROW 26
>>
>> LABEL bug
>> TEXT HELP
>> This is the first line, it is visible :D
>> This is the second line, it is hidden :(
>> ENDTEXT
>> MENU LABEL Bug
>> KERNEL /boot/bug
>>
>> You can clearly see the TEXT HELP box extending over the right
amounts
>> of rows, the last line of text is hidden however.
>> I suppose this is a bug or am I missing something?
>>
>> -- Sven-Hendrik
>>
>>     
>
> Are you using the text menu or the graphical menu?  I'm wondering if
you
> end up running out of screen...
>
> 	-hpa
>
>   
I'm using vesamenu.c32 as stated in the title. I don't think I'm running
out of screen space since another line of empty help box is still
displayed. Besides, I also get the issue if I try it with lines 15-17
(for instance).


Hey Sven, when I use menu.c32, my console only has 25 rows total.  The
second line is hidden.  When I use vesamenu.c32, I see both lines.  If I
set MENU COLOR HELP to have a fancy background colour, vesamenu.c32
shows me three lines with the background colour (with the two lines of
text).  If I use menu.c32, I see rows 24 and 25 with the background
colour, though row 25 doesn't show the expected second line of text.

Could it be that there is a mandatory final blank line as part of a help
text display, which _must_ be on-screen, even if it means obliterating a
previous line of text?  If that is the case, perhaps HELPMSGENDROW being
on 26 is overridden to become row 25 (with a 25-row display, such as my
menu.c32 test has).

This is my SYSLINUX.CFG file:

UI vesamenu.c32
MENU HELPMSGROW 24
MENU HELPMSGENDROW 26
MENU COLOR HELP 1;36;45 #a000ffff #a08000ff std

LABEL bug
  TEXT HELP
This is first line.
This is second line.
  ENDTEXT
  MENU LABEL Bug
  KERNEL /boot/bug

A difference from the file you gave was my use of the UI directive.
Perhaps this bug has been fixed?

- Shao Miller