[syslinux] [RFC][PATCH] fsc: convert the highmem.inc fromassembly to C code

[Miller, Shao]

-----Original Message-----
From: syslinux-bounces at zytor.com [mailto:syslinux-bounces at zytor.com] On Behalf Of Liu Aleaxander
Sent: Saturday, December 19, 2009 07:49
To: Feng Tang
Cc: syslinux at zytor.com; hpa at zytor.com
Subject: Re: [syslinux] [RFC][PATCH] fsc: convert the highmem.inc fromassembly to C code

Hi feng,

On Fri, Dec 18, 2009 at 9:44 PM, Feng Tang <feng.tang at intel.com> wrote:
> +static void *hex_dump(void *start, int dlen, const char *str)
> +{
> +       uint32_t *data = start;
> +       uint32_t i;
> +
> +       printf("Dump info for %s:\n", str);
> +       for (i = 0; i < dlen; i++)
> +               printf(" %08x ", data[i]);
> +       printf("\n");
> +}

I submitted a hexdump lib patch a few days ago, and it is really good
for debugging.  You can check it at here:
http://syslinux.zytor.com/archives/2009-December/013585.html .

And, hpa, I haven't merged it into my git tree, since I think it would
be better to let it be sited in com32/lib/ directory as a generic lib
function. So, hpa, what's your opinion?

Thanks!

-- 
regards
Liu Aleaxander

-----Original Message End-----

I haven't seen hex_dump() entered into the main codebase yet.

Not sure why the thread got crossed from the "Re: [syslinux] [Syslinux] [PATCH] [RFC] lib: add a hex dump libfunction" thread, but I've kept it anyway.

- Shao Miller