[syslinux] isohybrid patch 10

[P J P]

  Hi,

--- On Wed, 12/5/10, Geert Stappers <stappers at stappers.nl> wrote:
> isohybrid.pl prints usage when no paramaters are provided.
> isohybrid should do the same. This patch achieves that.

  I don't think that's necessary or makes much of the difference for a user. isohybrid.c shows that the boot.iso is required by way of the usage() message.

> 
> And I think this needs also be done
> 
> --- a/utils/isohybrid.c
> +++ b/utils/isohybrid.c
> @@ -331,7 +324,7 @@ initialise_mbr(uint8_t *mbr)
>  
>      extern unsigned char
> isohdpfx[][MBRSIZE];
>  
> -    memcpy(mbr, &isohdpfx[hd0 + 3 * partok],
> MBRSIZE);
> +    memcpy(mbr, &isohdpfx[hd0 + 3 *
> partok][0], MBRSIZE);
>      mbr += MBRSIZE;   
>                
>              /*
> offset 432 */
>  
>      tmp = lendian_int(de_lba * 4);
> 
> 
> At least for readability.
 
  Again, it's not very convincing.

Did you test if the isohybrid.pl and isohybrid.c does the *exact same* job or not? That's excluding the usage() message each displays.


Thanks.
---
Regards
    -P J P
PS: Please don't send me html/attachment/Fwd mails