[syslinux] [PATCH] com32/lib/syslinux/load_linux.c:cmdline truncated

Sebastian Herbszt herbszt at gmx.de
Sun May 30 05:37:23 PDT 2010


H. Peter Anvin wrote:
> On 05/19/2010 08:40 AM, Bodo Stroesser wrote:
>> Hi,
>> 
>> in syslinux-386, I think I've found a problem in
>>    com32/lib/syslinux/load_linux.c
>> that leads to cmdline being truncated unnecessarily when e.g.
>> linux.c32 is used.
>> 
>> The patch below fixes the problem for me. But I don't know,
>> whether the patch is safe in all cases. I tried to reproduce
>> the logic found in runkernel.inc, but I might have missed
>> something. So, feel free to tell me what's wrong with it.
>> 
>> Please CC me, as I'm not on the list.
>> 
> 
> 
> No, this is actively wrong.
> 
> There is nothing with versions 2.03, .04 or .05 which makes it safe to
> use 2048 bytes.  I have no idea what SLES11 did, but it sounds like a
> local change.
> 
> -hpa

2.6.16 is actually SLES 10 not 11. SLES 11 is 2.6.27 or 2.6.32. SLES 10
includes patches to increase the kernel command line size to 2048.

Sebastian




More information about the Syslinux mailing list