[syslinux] PXELINUX: DNS issue on unqualified names [PATCH][git-pull]

[Gene Cumm]

On Sun, Nov 14, 2010 at 14:42, H. Peter Anvin <hpa at zytor.com> wrote:
> On 11/14/2010 09:27 AM, Geert Stappers wrote:
>>
>> FWIW
>> commit 83ffac5bc53ba7a8626a1bc35e76cf4b3a781a37
>> Author: Gene Cumm <gene.cumm at gmail.com>
>> Date:   Sun Nov 14 11:13:27 2010 -0500
>>
>>     PXELINUX: Fix DNS resolver to properly use LocalDomain when needed.
>>
>> diff --git a/core/fs/pxe/dnsresolv.c b/core/fs/pxe/dnsresolv.c
>> index 2b263fa..e76f2f8 100644
>> --- a/core/fs/pxe/dnsresolv.c
>> +++ b/core/fs/pxe/dnsresolv.c
>> @@ -216,6 +216,7 @@ uint32_t dns_resolv(const char *name)
>>          p--; /* Remove final null */
>>          /* Uncompressed DNS label set so it ends in null */
>>          strcpy(p, LocalDomain);
>> +     while (*(p++)) {}
>>      }
>>
>
> Thanks for catching this bug!
>
> Please use instead:
>
>        p = stpcpy(p, LocalDomain);

Thank you.

-- 
-Gene