[syslinux] syslinux-4.03-pre4 + MCONFIG.devel + gcc 4.5

[H. Peter Anvin]

On 10/11/2010 12:44 PM, Sebastian Herbszt wrote:
>>
>> Yeah, not to mention the fact that that code is generic code which can
>> be done *much* better on x86...
>>
>> On the other hand, for 4.03 we should probably just drop the "inline".
>>
>> -hpa
> 
> After applying the appended patch i am stuck with
> 
> gcc -Wp,-MT,disk/bootloaders.o,-MD,disk/.bootloaders.o.d -Os -march=i386 -falign-functions=0 -falign-jumps=0 -falign-labels=0 
>  -ffast-math -fomit-frame-pointer -std=gnu99 -m32 -fno-stack-protector -fwrapv -freg-struct-return -fPIE -fno-exceptions 
>  -fno-asynchronous-unwind-tables -fno-strict-aliasing -falign-functions=0 -falign-jumps=0 -falign-labels=0 -falign-loops=0 
>  -mpreferred-stack-boundary=2 -g -mregparm=3 -DREGPARM=3 -D__COM32__ -nostdinc -iwithprefix 
> include -I. -I./sys -I../include -I../gplinclude -W -Wall -Wstrict-prototypes -Wno-clobbered -Werror -Wpointer-arith -Wwrite-strings 
>  -Wstrict-prototypes -Winline -DDYNAMIC_CRC_TABLE -DPNG_NO_CONSOLE_IO -DPNG_NO_WRITE_SUPPORTED -DPNG_NO_MNG_FEATURES -DPNG_NO_READ_tIME 
>  -DPNG_NO_WRITE_tIME -c -o disk/bootloaders.o disk/bootloaders.c
> cc1: warnings being treated as errors
> ../gplinclude/cpuid.h:176:24: error: 'test_bit' defined but not used
> make[2]: *** [disk/bootloaders.o] Error 1
> 

You can't drop inline declarations in .h files.

Really this stuff needs to be cleaned up and moved into a common header
file, but that's really post-4.03 material.

	-hpa