[syslinux] [syslinux:disklib] disklib: make CHS calculation match core/fs/diskio.c

H. Peter Anvin hpa at zytor.com
Wed Oct 13 14:30:56 PDT 2010


On 10/13/2010 08:36 AM, syslinux-bot for Michal Soltys wrote:
> Commit-ID:  9c8db7560e2dc83d1191bb2f90b4d4d0ae3d37d6
> Gitweb:     http://syslinux.zytor.com/commit/9c8db7560e2dc83d1191bb2f90b4d4d0ae3d37d6
> Author:     Michal Soltys <soltys at ziu.info>
> AuthorDate: Wed, 13 Oct 2010 10:57:36 +0200
> Committer:  Michal Soltys <soltys at ziu.info>
> CommitDate: Wed, 13 Oct 2010 10:57:36 +0200
> 
> disklib: make CHS calculation match core/fs/diskio.c
> 
> Signed-off-by: Michal Soltys <soltys at ziu.info>
> 

I note that this code still:

a) duplicates the code between read and write, and
b) doesn't check for CHS overflow.

This is particularly critical for write, obviously, since we could
corrupt a disk.

	-hpa




More information about the Syslinux mailing list