[syslinux] [PATCH] gfxboot: allow boot entry to start withlabelinstead of menu_label

[Sebastian Herbszt]

Colin Watson wrote:
> Regarding http://syslinux.zytor.com/archives/2010-July/014896.html,
> my configuration has blocks like this:
> 
>   label live
>     menu label ^Try Ubuntu without installing
>     kernel /casper/vmlinuz
>     append  file=/cdrom/preseed/ubuntu.seed boot=casper initrd=/casper/initrd.lz quiet splash --
> 
> Without my patch (from what I can remember), boot() wanted cmdline to
> look something like:
> 
>   ^Try Ubuntu without installing file=/cdrom/preseed/ubuntu.seed boot=casper initrd=/casper/initrd.lz quiet splash --
> 
> ... rather than the more sensible:
> 
>   live file=/cdrom/preseed/ubuntu.seed boot=casper initrd=/casper/initrd.lz quiet splash --

With the above config the module will pass "^Try Ubuntu without installing" to gfxboot core
and it will pass it back as part of the cmdline. The core will not return "live" as long as 
"MENU LABEL" is supplied.
The config parser sets menu_ptr->label = menu_ptr->menu_label = "live" on the "LABEL" statement.
It sets menu_ptr->menu_label = "^Try Ubuntu without installing" on "MENU LABEL".
menu_ptr->menu_label is then passed to gfxboot core which returns the menu index and the cmdline
back to boot(). There cmdline is checked if it starts with menu_ptr->menu_label, which contains the
parameter from LABEL or MENU LABEL if available.

What part of the problem the patch is fixing am i missing?

> I considered whether this was my fault, but my use seems to be in line
> with doc/menu.txt.

doc/menu.txt doesn't apply to gfxboot. The module only supports MENU LABEL as a simplification
if a full theme/config is not needed.

Sebastian