[syslinux] [PATCH] com32: Do not use centralized bitops header in vsscanf

[H. Peter Anvin]

On 04/04/2011 06:48 AM, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming at linux.intel.com>
> 
> Partially revert "com32: add a centralized bitops header"
> 
> This reverts part of commit db74cf6c4182f40ecf7fad1f04799d09d82f896d.
> 
> The usage of the centralized bitops in com32/lib/vsscanf.c is not
> correct because the bitmap that we're accessing is too large for the
> 'bt', 'bts' and 'btc' instructions to operate on, i.e. the
> instructions cannot address all the bits of the bitmap as the size of
> 'matchmap' is 32 bytes.
> 

bt/bts/btc can operate on "arbitrary" large memory objects (in practice
they are limited to 256 GiB in 32-bit mode, but that's not really an
issue here.)

Was this something you observed by code inspection, or did you actually
see a failure?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.