[syslinux] [PATCH] com32: Do not use centralized bitops header in vsscanf
H. Peter Anvin
hpa at zytor.com
Mon Apr 4 10:40:06 PDT 2011
On 04/04/2011 09:44 AM, Matt Fleming wrote:
> On Mon, 04 Apr 2011 09:30:01 -0700
> "H. Peter Anvin" <hpa at zytor.com> wrote:
>
>> bt/bts/btc can operate on "arbitrary" large memory objects (in
>> practice they are limited to 256 GiB in 32-bit mode, but that's not
>> really an issue here.)
>
> Ahh, d'oh. I misread the x86 instruction set reference manual.
>
>> Was this something you observed by code inspection, or did you
>> actually see a failure?
>
> I'm actually seeing a failure on the elflink branch (after merging
> master into elflink). The sscanf() call in
> com32/lib/sys/module/exec.c::module_load_dependences() isn't working
> properly, i.e. you get different results before and after the commit I
> pointed out in my patch.
>
As we discussed on IRC, found the bugs (multiple) and pushed out the
fixes on the master branch.
Thanks!
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
More information about the Syslinux
mailing list