[syslinux] Missing Error Condition Check in core/fs/fs.c

H. Peter Anvin hpa at zytor.com
Tue Aug 2 13:24:14 PDT 2011


On 08/02/2011 01:14 PM, Shao Miller wrote:
> 
>  From c9e609b14db68bed620aa911ed4f3587702d2dd3 Mon Sep 17 00:00:00 2001
> From: Shao Miller <shao.miller at yrdsb.edu.on.ca>
> Date: Tue, 2 Aug 2011 15:58:50 -0400
> Subject: [PATCH] core: Run Nindent on core/fs/fs.c
> 
> Signed-off-by: Shao Miller <shao.miller at yrdsb.edu.on.ca>
> ---
>   core/fs/fs.c |   58 
> ++++++++++++++++++++++++++++------------------------------
>   1 files changed, 28 insertions(+), 30 deletions(-)
> 
> diff --git a/core/fs/fs.c b/core/fs/fs.c
> index ad2fb37..95d747d 100644
> --- a/core/fs/fs.c
> +++ b/core/fs/fs.c
> @@ -6,7 +6,7 @@
>   #include "cache.h"
> 
>   /* The currently mounted filesystem */
> -struct fs_info *this_fs = NULL;        /* Root filesystem */
> +struct fs_info *this_fs = NULL;    /* Root filesystem */
> 
>   /* Actual file structures (we don't have malloc yet...) */
>   struct file files[MAX_OPEN];
> @@ -77,7 +77,7 @@ void _close_file(struct file *file)
>    * Convert between a 16-bit file handle and a file structure
>    */
> 
> -void pm_load_config(com32sys_t *regs)
> +void pm_load_config(com32sys_t * regs)

This is really a bug in Nindent... there shouldn't be a space here.

Please don't run Nindent unless the formatting is *totally* screwed;
automatic indentation usually creates more problems than it solves.

	-hpa




More information about the Syslinux mailing list