[syslinux] bzimage: Merge memory types

Matt Fleming matt at console-pimps.org
Wed Aug 10 15:11:28 PDT 2011


On Tue, 2011-08-09 at 01:44 +0200, Maarten Lankhorst wrote:
> Fix failure to boot because of >128 e820 entries
> 
> Signed-off-by: Maarten Lankhorst <m.b.lankhorst at gmail.com>

Applied, thanks.

This is great, you keep sending me patches for things on my TODO
list ;-) With this patch applied does your machine now boot?

Note that efilinux is still missing support for > 128 e820 entries after
merging adjacent ones. Support for this requires filling out a struct
setup_data linked-list and pointing to it from hdr.setup_data. Would you
be able to test a patch for this (obviously you'll need to revert your
bzimage patch I just applied while you're testing).

> Unrelated, I'm pretty sure that that print statement of 'invalid
> efi memory descriptor type' wont work because of the ExitBootServices
> On my system adding a similar print statement for warning of merger
> caused it to reboot.

Yeah, that does indeed look wrong. It's not OK to call Print() after
ExitBootServices() because Print() can allocate memory. I'll fix that.

> Also can EfiRuntimeServicesCode be changed from unusable to reserved?
> and perhaps EfiUnusableMemory to unusable. ;)

Heh, whoops. I'll make the change, thanks.

-- 
Matt Fleming, Intel Open Source Technology Center




More information about the Syslinux mailing list