[syslinux] [RFC][PATCH 4/4] elflink: Move cli lib code out of core

[Jim Cromie]

On Thu, Feb 17, 2011 at 5:03 PM, Matt Fleming <matt at console-pimps.org>wrote:

> From: Matt Fleming <matt.fleming at linux.intel.com>
>
> The cli code does not belong in the core, so move it out into an ELF
> module. Now, we can share the cli library code among different
> modules, namely the new cmdline.c32 and ui.c32 modules.
>
> This change also provides a good example of how the core can load
> modules on demand. For instance, as the core still needs to drop the
> user to a command prompt sometimes (like if we're aborting) we can
> execute the new cmdline.c32 module.
>
> There are plenty of other pieces of code that could be moved into a
> module such as the config parser and kernel loader. So further
> reductions in core size are definitely possible.
>
> Signed-off-by: Matt Fleming <matt.fleming at linux.intel.com>
> ---
>

hi Matt,

in 0/4 msg, you RFC'd your approach here.
Is there something specific you thought needed discussion ?
Im not active here, but nothing struck me as less than straight forward,

except perhaps a git usage question:


>  com32/elflink/modules/cli.c     |  437
> +++++++++++++++++++++++++++++++++++++++
>  core/elflink/cli.c              |  410
> ------------------------------------
>

I looked at those 2 lines, and wondered why git didnt show them as a rename.
If this were done in 2 separate steps, would it appear as a rename
automatically,
or would you need to do something specific/different ?
Would 2 steps have left you with a non-functional revision, bad for bisect ?
Is there a simple way to reformulate your patch to make it both a rename,
and bisectable ?

Oh. and in Makefile, you added cli.32 to an otherwize unchanged line,
and added 2 new modules to newline below it.  I wasted a few seconds
scanning the -+ lines for the difference, having expected just 1 new line.