[syslinux] [RFC][PATCH 4/4] elflink: Move cli lib code out of core

Jim Cromie jim.cromie at gmail.com
Thu Feb 24 12:28:06 PST 2011


On Wed, Feb 23, 2011 at 7:25 PM, H. Peter Anvin <hpa at zytor.com> wrote:

> On 02/23/2011 05:00 AM, Jim Cromie wrote:
> >
> >>  com32/elflink/modules/cli.c     |  437
> >> +++++++++++++++++++++++++++++++++++++++
> >>  core/elflink/cli.c              |  410
> >> ------------------------------------
> >>
> >
> > I looked at those 2 lines, and wondered why git didnt show them as a
> rename.
> > If this were done in 2 separate steps, would it appear as a rename
> > automatically,
> > or would you need to do something specific/different ?
>
> No, it just means the patch was produced without the -M flag in git.
>
> I think its insufficient here; the new file has different line count than
the 1st, so it cant be a verbatim copy as is.  This is why I was looking
for 2 patches
- 1st to rename w no diff to inspect,
- 2nd to make the mods which deleted the 27 extra lines.
Sorry I wasnt more clear on that particular.

So Matt, is your plan something like:
 to create a com32/ldlinux dir,
 or maybe convert core/elflink to com32/ldlinux, with the needed makefile
adjustments,
 then move cli.c there ?



More information about the Syslinux mailing list