[syslinux] [GIT PULL] elflink fixes

Shao Miller Shao.Miller at yrdsb.edu.on.ca
Fri May 4 10:21:33 PDT 2012


On 5/4/2012 12:40, H. Peter Anvin wrote:
> On 05/04/2012 08:28 AM, Shao Miller wrote:
>> On 5/4/2012 11:07, Paulo Alcantara wrote:
>>> Hi Matt, From: Matt Fleming <matt at console-pimps.org> Date: Fri, 04 
>>> May 2012 11:05:43 +0100
>>>> -static const char * cmd_reverse_search(int *cursor) +static const 
>>>> char * cmd_reverse_search(int *cursor, clock_t *kbd_to, + clock_t 
>>>> *tto) 
>>> Please, fix coding style here.
>>>
>>> E.g.: change "static const char * cmd_reserve..." to "static const 
>>> char *cmd_reverse..." 
>>
>>
>> Heheh. I prefer:
>>
>>   type * ptr
>>
>> over:
>>
>>   type *ptr
>>
>> for readable code. :
>>
>> However, I think the majority of Syslinux code uses the latter.
>>
>
> Yes, and it Linux kernel, and Syslinux, style.

And /syslinux/doc/CodingStyle.txt and syslinux/devel/Nindent mean that 
this is certainly the way it ought to be, in Syslinux.

> The "space after *" notion doesn't work when you're dealing with more 
> complex types anyway.

   char (* sure_it_does(int x))[10] { return 0; }

It just helps my eyeballs-and-brain to spot the beginning of the 
identifier a split-second sooner.  Probably not the right forum to have 
brought it up in. :)  I just simply meant:

On 5/4/2012 11:07, Paulo Alcantara wrote:
> Please, fix coding style here. 

to:

On 5/4/2012 11:07, Paulo Alcantara wrote:
> Please, use Linux/Syslinux coding style here. 

Hee hee hee.

- Shao Miller



More information about the Syslinux mailing list