[syslinux] [PATCH] Update diag/mbr instruction to match the current filename.

[Jean-Christian de Rivaz]

Hi Gene,

Thanks for the quick answer.

Le 26. 05. 12 23:30, Gene Cumm a écrit :
> On May 26, 2012 5:03 PM,<jc at eclis.ch>  wrote:
>>
>> From: Jean-Christian de Rivaz<jc at eclis.ch>
>>
>> I suspect that some instructions about how to use the diag/mbr was not
>> updated when the source file was renamed to handoff.S. Here is a simple
>> proposition to fix that.
>>
>> Jean-Christian de Rivaz
>> ---
>>   diag/mbr/README    |    4 ++--
>>   diag/mbr/handoff.S |    4 ++--
>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/diag/mbr/README b/diag/mbr/README
>> index fb7a7dd..080d65b 100644
>> --- a/diag/mbr/README
>> +++ b/diag/mbr/README
>
> Nack.  This section of README is _not_ specific to handoff.bin.  I use as a
> generic name of an MBR.

Ok, I understand but this README is right into the directory where a 
natural 'make' produce a handoff.bin target, not a mbr.bin. This README 
look read like a 'handoff.bin usage instruction', and I was a bit 
speechless when I first read it and did not find any reference to the 
handoff.bin file in the commands instruction. At least, I suggest to add 
a explanation that the mbr.bin in the generic command is to be replaced 
by handoff.bin in this specific case. When I am a newbie in a project, I 
found that 'ready to use commands' help a lot to understand what's going on.

>> diff --git a/diag/mbr/handoff.S b/diag/mbr/handoff.S
>> index 7af3fde..ab8582b 100644
>> --- a/diag/mbr/handoff.S
>> +++ b/diag/mbr/handoff.S
>> @@ -43,11 +43,11 @@
>>   * Install instructions (assuming your target is /dev/dev; file or block
> device):
>>   *
>>   * MBR:
>> - * dd conv=notrunc bs=440 count=1 if=mbr_ho.bin of=/dev/dev
>> + * dd conv=notrunc bs=440 count=1 if=handoff.bin of=/dev/dev
>>   *
>>   * VBR/PBR (should work for FAT12/16/32, ext[234]fs, btrfs):
>>   * echo -en "\0353\0130\0220" |dd conv=notrunc bs=1 count=3 of=/dev/dev
>> - * dd conv=notrunc bs=2 count=210 seek=45 if=mbr_ho.bin of=/dev/dev
>> + * dd conv=notrunc bs=2 count=210 seek=45 if=handoff.bin of=/dev/dev
>>   */
>>
>>   // #define DEBUG_MARKER1       /* Insert markers in binary */
>> --
>> 1.7.2.5
>
> Ack.  I did rename it during development.  Thanks!
>
> Jean-Christian, I'll prepare this patch with you as author and signoff on
> it unless you'd rather make it fetchable.

Don't known how to make it fetchable quickly. I will send a patch V2 
with only the second part in the hope that this save time to you. feel 
free to use the method that sound the best to you.

Jean-Christian