[syslinux] [PATCH 12/23] com32/chain: cleaner variable names
Geert Stappers
stappers at stappers.nl
Tue Nov 6 04:49:45 PST 2012
On Tue, Nov 06, 2012 at 01:43:21PM +0100, Michal Soltys wrote:
> On 06.11.2012 11:07, Geert Stappers wrote:
> >On Tue, Nov 06, 2012 at 01:32:46AM +0100, Michal Soltys wrote:
> >>[PATCH 12/23] com32/chain: cleaner variable names
<snip/>
> >>index da96b3d..14e74de 100644
> >>--- a/com32/chain/partiter.c
> >>+++ b/com32/chain/partiter.c
<snip/>
> >>- iter->dos.cebr_lba = 0;
> >>- iter->dos.nebr_lba = iter->dos.bebr_start;
> >>+ iter->dos.nebr_lba = dp->start_lba;
> >>+ iter->dos.nebr_siz = dp->length;
> >>
> >> iter->index0--;
> >> }
> >
} >FWIW Some how I'm missing a line like
> >} + iter->dos.nebr_lba = 0;
> >
>
> prep_base_ebr() is just single-shot setup - so it sets bebr_lba
> (necessary to calculate position of each subsequent logical
> partition, line 366) and 1st nebr_lba (loop control, sanity check).
> At this point, nebr_lba is set to lba of first encountered extended
> partition (== bebr) and after the first iteration cebr becomes nebr.
>
> As for initialization, everything is 0ed by default (pi_alloc()),
> and ctors take care of the rest should something else be needed.
Okay, thanks for the elaboration.
Groeten
Geert Stappers
--
> And is there a policy on top-posting vs. bottom-posting?
Yes.
More information about the Syslinux
mailing list