[syslinux] [PATCH 03/23] com32/chain: use anonymous and unnamed aggregates

Michal Soltys soltys at ziu.info
Thu Nov 8 00:45:38 PST 2012


On 08.11.2012 02:44, Shao Miller wrote:
> On 11/5/2012 19:32, Michal Soltys wrote:
>> Signed-off-by: Michal Soltys <soltys at ziu.info>
>> int index0;
>> - union _sub {
>> - struct _dos {
>> + union {
>> + struct {
>> 
>> ...
>> 
>> - } sub;
>> + };
>> };
>>
>> extern const struct itertype * const typedos;
>>
> 
> Personally, I'd rather not, but anonymous members of this sort are in 
> C11... At least it removes the reserved identifier usage. :)
> 
> Did you spot anonymous members being used elsewhere in the code-base, or 
> will this be the first such usage that you're aware of?
>

They were previously present in chain.c, when iterators were still part
of it (that is, before my split patches were merged). I looked back at
it and thought that perhaps I overdid earlier changes. For reference:

git show 4c3e2f0e:com32/modules/chain.c
around line 470

> - Shao Miller
> 





More information about the Syslinux mailing list