[syslinux] [PATCH 01/23] com32/chain: update licenses

[Michal Soltys]

On 08.11.2012 01:58, Shao Miller wrote:
> On 11/5/2012 19:32, Michal Soltys wrote:
>> ##
>> -## Copyright 2001-2010 H. Peter Anvin - All Rights Reserved
>> +## Copyright 2003-2009 H. Peter Anvin - All Rights Reserved
>
> What happened to the 2001 (and 2002), here? Is that a simple
> copy'n'paste error, or does the Makefile not actually date back to 2001?

Copy-paste error.

For the record, I followed HPA's suggestion about which kind of license 
to put where, not 100% sure if correctly though.

>
> I know that it's almost ubiquitous (including in the Syslinux
> code-base), but I must [weakly] protest. From C99, 7.1.3p1, first item:
>
> "All identifiers that begin with an underscore and either an uppercase
> letter or another underscore are always reserved for any use."
>
> p2 has:
>
> "...If the program declares or defines an identifier in a context in
> which it is reserved (other than as allowed by 7.1.4), or defines a
> reserved identifier as a macro name, the behavior is undefined."
>
> Now a C "implementation" (in many cases) could be roughly considered to
> be "computer + operating system + C translator + C libraries." Since
> Syslinux implements portions of "operating system" and "C libraries," it
> can somewhat be justified. However, if GCC (as "C translator") or a
> future C Standard disagrees, we have to change it.
>
> Anyway, that's not a criticism of your code! You are merely sticking
> with what much of the rest of the code-base does.
>

Good catch and no problems, one sed and it's fixed =)

OTOH, what about using #pragma once ? Seems much cleaner and anything 
that could be used for compiling syslinux supports it (I think). From 
other projects, I think systemd has recently switched from #ifdefs pairs 
to #pragma