[syslinux] please revert MENU CLEAR so to make it optional again

Matt Fleming matt at console-pimps.org
Tue Nov 27 05:22:06 PST 2012


On Mon, 2012-11-26 at 10:26 -0800, H. Peter Anvin wrote:
> The logic was that we have an effective "MENU CLEAR" default in 4.06 for
> vesamenu.c32, but that isn't actually true... we have it only as long as
> the user is *not* using "quiet vga=current", which is what a lot of the
> distributions like to run with.
> 
> So I think you're right, we probably should revert it.
> 
> *HOWEVER*, please be aware that that will not actually bring back the
> 4.06 behavior of clearing the screen implicitly when vesamenu.c32 is in
> use and "quiet vga=current" is not used.

OK folks, I'm going to revert this commit for Syslinux-5.00-pre11. We'll
have to fix the issue it was supposed to solve a different way.

Peter, am I correct in thinking that,

commit 6ab02b6682c0b693b3e4f9afcc2ab8775f804f0a
Author: H. Peter Anvin <hpa at zytor.com>
Date:   Tue Mar 27 14:39:46 2012 -0700

    menu: Make "menu clear" the default
    
    Make "menu clear" the default... it was sort of implicitly so at least
    for vesamenu when using the old system, since we would end up zapping
    the mode when any output happened, but that no longer is the case.
    
    Also move the cursor to the top of the screen.
    
    Signed-off-by: H. Peter Anvin <hpa at zytor.com>

was intended to provide a better solution for solving,

commit 87320b8de8f331b9c1810e98e24426e70b0ae29f
Author: Matt Fleming <matt.fleming at intel.com>
Date:   Fri Mar 9 10:53:52 2012 +0000

    ldlinux: Disable VGA graphics when loading a kernel
    
    The state of the graphics hardware is unknown when we're about to load
    a new kernel. It could be running in VGA mode, so let's disable VGA
    graphics before passing control to the kernel.
    
    The old assembly version of this code made extensive used of
    writestr(), which always calls vgaclearmode(). In the C version we're
    using printf() and so need to call vgaclearmode() directly. Doing it
    directly has the added advantage of documenting exactly where we need
    to reset the graphics hardware.
    
    Signed-off-by: Matt Fleming <matt.fleming at intel.com>

since the above commit from me got reverted (you point out that it
breaks vesacon)?

-- 
Matt Fleming, Intel Open Source Technology Center




More information about the Syslinux mailing list