[syslinux] Menu system bug - MENU DEFAULT not working

[Tomas M]

Thank you very much, it is really an improvement!
It is much better now. Yet still not perfect.

Attached is sample menu. It may look too complex, but I believe the
menu is very correct, it is auto-generated by a tool, not manually
written down, so it should be error-free (unless the tool which
generates it is broken)

It seems that the menu works on the first impression, but if you keep
checking and unchecking the options for a while, you will see that the
'cursor' starts to jump to wrong positions sometime.


Tomas M



On Tue, Oct 9, 2012 at 1:03 PM, Matt Fleming <matt at console-pimps.org> wrote:
> On Thu, 2012-09-06 at 23:04 +0200, Tomas M wrote:
>> Yes of course, as I wrote in my previous post, I tried unique labels,
>> it makes no change.
>> MENU DEFAULT just doesn't work. You can try it yourself, just use the
>> following config, and select the second row option (OptionB) ... It
>> should show a menu where the second row is default, but instead it
>> shows a menu with first row default:
>
> Tomas, thanks for the example config file.
>
> Can you apply the following patch to 4.06-pre12 and see if your problem
> is fixed?
>
> diff --git a/com32/menu/readconfig.c b/com32/menu/readconfig.c
> index 0ac2564..431017f 100644
> --- a/com32/menu/readconfig.c
> +++ b/com32/menu/readconfig.c
> @@ -392,7 +392,9 @@ static void record(struct menu *m, struct labeldata *ld, const char *append)
>             break;
>         }
>
> -       if (ld->menudefault && me->action == MA_CMD)
> +       if (ld->menudefault && (me->action == MA_CMD ||
> +                               me->action == MA_GOTO ||
> +                               me->action == MA_GOTO_UNRES))
>             m->defentry = m->nentries - 1;
>      }
>
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: syslinux.cfg
Type: application/octet-stream
Size: 10533 bytes
Desc: not available
URL: <http://www.zytor.com/pipermail/syslinux/attachments/20121009/e9b04584/attachment.obj>