[syslinux] [PATCH] add additional checks to ext2 loader
Paulo Alcantara
pcacjr at zytor.com
Tue Oct 9 10:32:29 PDT 2012
From: Frediano Ziglio <frediano.ziglio at citrix.com>
Date: Thu, 2 Aug 2012 09:32:36 +0100
> e_inode = ext2_get_inode(fs, inr);
> - if (!(inode = alloc_inode(fs, inr, sizeof(struct ext2_pvt_inode))))
> + if (!e_inode || !(inode = alloc_inode(fs, inr, sizeof(struct ext2_pvt_inode))))
> return NULL;
You could at least refactor this. This if-statement is just horrible and hard to
read at glance.
Paulo
More information about the Syslinux
mailing list