[syslinux] Final line of menu selectable even if it is disabled

Geert Stappers stappers at stappers.nl
Tue Oct 9 12:09:22 PDT 2012


On Tue, Oct 09, 2012 at 01:10:31PM +0100, Matt Fleming wrote:
> On Wed, 2012-09-05 at 10:53 +0100, Matt Sephton wrote:
> > I have a menu conf as follows:
> > 
            <snip/>
> > 
> > Any thoughts?
> 
> Matt, it does indeed look like you're hitting an edge case.
> 
> Could you apply the following patch on top of 4.06-pre12 and see whether
> your issue is resolved?
> 
> diff --git a/com32/menu/menumain.c b/com32/menu/menumain.c
> index 5b3f6bd..7c58979 100644
> --- a/com32/menu/menumain.c
> +++ b/com32/menu/menumain.c
> @@ -958,8 +958,7 @@ static const char *run_menu(void)
>  
>  	case KEY_DOWN:
>  	case KEY_CTRL('N'):
> -	    while (entry < cm->nentries - 1) {
> -		entry++;
> +	    while (++entry < cm->nentries) {
>  		if (entry >= top + MENU_ROWS)
>  		    top += MENU_ROWS;
>  		if (!is_disabled(cm->menu_entries[entry]))
> 
> 

Message from Matt Septhon

  Sorry I'm not in a position to build my own binary at the moment.


Groeten
Geert Stappers
-- 
> And is there a policy on top-posting vs. bottom-posting?
Yes.



More information about the Syslinux mailing list