[syslinux] [PATCH 1/2] Match comment with code

Ady ady-sf at hotmail.com
Sun Dec 15 11:21:31 PST 2013


> Op 2013-12-15 om 17:39 schreef Ferenc Wagner:
> > Ruben Kerkhof <ruben at rubenkerkhof.com> writes:
> > 
> > >  	/* 80 00 00 00 ee 00 00 00
> > > -	   - bootable partition, type EFI (EE), no CHS information */
> > > +	   - bootable partition, type EFI (ED), no CHS information */
> > 
> > Please fix the previous comment line as well.
> 
> As I understand that, so in _my words_:
> 
> Hello Ruben,
> 
> Thank you for your patch to the Syslinux project.
> 
> You spotted indeed a mismatch between code and comment.
> 
> Reviewing your patch revealed other mismatch.
> 
> Please rework your patch and submit it again to the mailinglist.
> 
> 
> 
> Groeten
> Geert Stappers
> 
> -- 
> $ git diff -U5 mbr/gptmbr.S
> diff --git a/mbr/gptmbr.S b/mbr/gptmbr.S
> index 7f450d3..327cfa1 100644
> --- a/mbr/gptmbr.S
> +++ b/mbr/gptmbr.S
> @@ -191,12 +191,12 @@ found_part:
>         xchgw   %ax,%cx         /* Set up %cx for rep movsb further down */
>  
>         movw    $dssi_out,%di
>         pushw   %di
>  
> -       /* 80 00 00 00 ee 00 00 00
> -          - bootable partition, type EFI (EE), no CHS information */
> +       /* 80 00 00 00 ed 00 00 00
> +          - bootable partition, type EFI (ED), no CHS information */
>         xorl    %eax,%eax
>         movb    $0x80,%al
>         stosl
>         movb    $0xed,%al
>         stosl
> _______________________________________________
 
Please forgive my ignorance. Could someone point to some "standard" 
or some documentation where the supposedly correct / adequate value 
(EE or ED or whichever) is specifically listed and/or explained?

For example, where is this "ED" partition type ID listed where it 
specifically makes reference (or in relation) to *EFI*?

The reason I ask is because I know about "EE" and "EF" partition 
typed IDs in relation to EFI, but not about "ED" (in relation to 
EFI). Perhaps I am just misunderstanding this email thread (?).

TIA,
Ady.


More information about the Syslinux mailing list